Cobblemon:Crzbrain

● v3.2 Fixes - AI Quality + Performance + Persistence (~55 fixes across 17 files)

Critical: RL + Persistence (7 fixes)

1. RL: Fixed REINFORCE score function - Was advantage * (1-probability), now (advantage / probability).coerceIn(-3, 3) - same fix in experience replay
2. RL: EMA baseline - Was cumulative average (stale after thousands of episodes), now 0.99avg + 0.01reward
3. RL: O(n) chooseBestAction - Was O(n²) recomputing totalWeight per action inside maxByOrNull
4. RL: Thread-safe stats - totalUpdates/totalRewardsPositive/totalRewardsNegative changed to AtomicInteger; reset() now also clears replayBuffers
5. AdaptiveLearning: Full persistence - Was completely lost on restart! Now saves/loads 6 JSON files in config/CRZbrain/adaptive/
6. AdaptiveLearning: Fixed importStrategy - Floor was 0.225 (below failure threshold), now maxOf(rate * 0.3, 0.4). Also fixed equals vs contains for context matching, capped trainerPatterns at 200
7. CRZbrainMod: Shutdown saves 4 missing systems - Added ExternalAILearning, EmotionalMomentum, LearningContextIntegration, AdaptiveLearning to shutdown. Added LearningSystem.forceSave() to periodic async saves

High: Bug Fixes (14 fixes)

1. SRG: Atomic read-and-remove for feedback attribution - Was race condition where another thread could read null between get() and remove()
2. SRG: English keywords added to all scoring/filtering - Was Italian-only, English-speaking players got random responses instead of contextual ones
3. SRG: Fixed part.first() crash - Changed to firstOrNull()?.isUpperCase() == true. Added probability gates to shiny/seasonal/first-Pokemon responses
4. SRG: Cross-Pokemon RL transfer - Filter was using contains (impossible match on context strings), fixed to startsWith
5. ExternalAILearning: English keywords - Added EN keywords to detectTopic (10 categories) and detectEmotion (6 categories)
6. ExternalAILearning: Atomic writes + multiple fixes - All 11 files now use temp+rename atomic writes. Fixed diversityScore Gson deserialization. Fixed extractOpener while-loop. Added read-time quality decay
7. DeepUnderstanding: Fixed 4 broken Regex - Escaped :) :( >:) special characters. Elongation pattern now requires 2+ repeated chars
8. DeepUnderstanding: Fixed detectEmotion double-call - Was computing emotion twice per message. Added caps: 500 words/Pokemon in learnedMeanings, 200 players in communicationPatterns
9. IntelligenceEvolution: Fixed totalKnowledge - Wasn't decremented after knowledge eviction. Fixed learningSpeed cap at 3.0 using maxOf instead of overwrite
10. IntelligenceEvolution: Word-boundary Regex - "male" and "no" were matching inside other Italian words. Skip English context keys in enrichment. Minimum 2-word overlap for deductive inference
11. LCI: Thread-safe inner maps - Changed mutableMapOf() to ConcurrentHashMap() inside getOrPut calls. Fixed quality score normalization (divide by totalWeightUsed)
12. LCI: Feedback detection - Now requires keyword AND sentiment agreement. Was false-positive on common Italian words like "sono", "pokemon"
13. APM: Fixed substring matching - Sentiment markers used substring contains (false positives). Now split into single-word Set checks + explicit multi-word contains
14. EmbeddedAIProvider: Moods actually work - EXCITED was a no-op, ANGRY destroyed ellipses, TIRED never triggered. All 4 maps changed to ConcurrentHashMap

Medium: Performance (14 fixes)

1. APM: Eliminated ~200 allocations per call - All per-call maps, lists, sets, regex moved to object-level vals
2. APM: Sentiment cache String key - Was using hashCode (collisions). Added caps: 100 topics, 200 actions. synchronizedList for inner lists. Atomic file writes
3. LearningSystem: Removed sync I/O from markDirty - Was calling checkAutoSave() which could block main thread. Pre-compiled 17 regex
4. SmartConversation: Pre-compiled 20+ regex - normalizeMessage was creating new Regex objects per call. Hoisted SPECIES_QUIRKS map to object level
5. MoveAnimationSystem: Cached getNearbyPlayers - Was doing 16 entity searches per attack, now does 2 (query once, pass list to all sub-functions)
6. PokemonDefenseSystem: Cached entity search - One search per player shared across all Pokemon. Replaced sortedWith().first() with minWithOrNull()
7. MemorySystem: Bulk eviction - removeAt(0) in while loop replaced with subList(0, excess).clear() (single array shift)
8. LanguageGrowth: Word-boundary replacement - upgradeVocabulary now uses Regex word boundaries to avoid replacing inside other words
9. EmotionalMomentum: Fixed stale lastUpdate - Added timestamp update in applyEmotionalTransfer and applyBuildup (was never refreshed, states appeared inactive)
10. IntelligenceEvolution: Sliding window learning rate - Was using lifetime cumulative average (never changed after early episodes). Now uses window of last 50 results
11. AdaptiveLearning: Normalized activityPattern - Was accumulating 0.1 per call (grew unbounded). Now stores raw counts, normalizes at read-time. feedbackHistory changed to ArrayDeque for O(1) removeFirst
12. CRZbrainMod: Fixed sender duplicate - allNearbyPlayers included the sender themselves. Added cleanup of lastChatLearnTime on player disconnect
13. ExternalAILearning: Removed double loadData() - init block was calling loadData() which was also called at server start
14. LCI: Debounced saveContextWeights - Added dirty flag, only saves when explicitly called instead of on every weight update