CobblemonQuests

[1.6.2] — 2026-04-20 — "Deep Audit Patch"

Follow-up fixes found during a systematic audit of reward and GUI flows. No config changes required — safe drop-in replacement.

Fixed — Streak rewards never fired

• StreakManager.onDailyResetCompleted was dead code — no caller. The streak counter incremented, but the configured rewards for day 3, day 7, day 14, and day 30 streaks never paid out.
• QuestAssigner.assignDailies now invokes the streak reward payout when the counter advances. Online players receive the reward on daily reset; offline players get the increment stored but payouts wait (matching the original intent — items need an inventory).

Fixed — Paid reroll currency lost on no-replacement

• QuestDetailGui.attemptReroll withdrew Stars or PokéDollars before checking whether the pool actually had a replacement quest. If the pool was exhausted, the player lost the currency with nothing in return.
• Now: slot lookup happens first, currency is charged, and if the reroll still comes back empty the charge is refunded via new ImpactorEconomy.refundStars / refundPokeDollars helpers (which do not inflate the "Most Stars" leaderboard).
• Free-reroll counter is similarly rolled back when a free roll produces no replacement.

Fixed — Hub GUI rendered quests without bonus lore / auto-yellow

• The main menu (QuestsHubGui.renderQuestDye) duplicated a slimmer version of QuestItemRenderer.render and bypassed the 1.6.1 auto yellow-number highlighting for quest descriptions.
• It also omitted the bonus objective description line and the bonus rewards section, so players only saw bonus progress without knowing what the bonus task was or what it rewarded.
• Fixed: descriptions run through the shared autoHighlightNumbers helper; bonus description + bonus rewards are now rendered.

Fixed — Weekly reroll could pick a different quest than it showed

• QuestAssigner.rerollWeekly called pool.pickWeekly(1, blocked) twice in the same branch — once to check isEmpty(), once to grab the result — which could return different quests on the two calls.
• Now a single call, result cached.

Added — Offline rewards queue (community goals)

• CommunityGoalManager.onGoalComplete used to iterate server.getPlayerManager().getPlayerList(), so contributors who logged off before the goal completed received nothing.
• All contributors (including offline) are now rewarded. Offline payouts are queued in PlayerQuestData.pendingRewards (serialized in the player data file) and delivered on next login with a "★ You have rewards waiting! ★" chat announcement. COMMAND rewards are skipped for offline players since {player} substitution requires the player to be online anyway.

Fixed — Hidden quest could appear twice in list

• If a single catch matched two hidden quest triggers at once (e.g. species catch + lifetime-catch milestone), HiddenQuestTrigger could add the same quest to activeHiddens twice — showing a duplicate row the player couldn't deduplicate.
• Added a "already discovered or active" guard to discover().

Internal

• New ImpactorEconomy.refundStars / refundPokeDollars methods for refunds that don't count toward lifetime earnings.
• QuestItemRenderer.autoHighlightNumbers is now public for reuse.
• PlayerDataSerializer serializes / deserializes the new pendingRewards list.